Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format of callout header #32325

Closed
wants to merge 1 commit into from
Closed

Fix format of callout header #32325

wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Callout header shows up as **Why write a service?**

Issue Number: N/A

What is the new behavior?

Change from alert to callout with proper header.

Does this PR introduce a breaking change?

  • Yes
  • No

@jbogarthyde jbogarthyde requested a review from a team as a code owner August 26, 2019 19:03
@jbogarthyde jbogarthyde self-assigned this Aug 26, 2019
@ngbot ngbot bot modified the milestone: Backlog Aug 26, 2019
@jbogarthyde
Copy link
Contributor Author

@IgorMinar @alxhub
This is a very minor format fix, just one line -- but the error looks ugly, let's get it fixed.

@mary-poppins
Copy link

You can preview 82b5bc7 at https://pr32325-82b5bc7.ngbuilds.io/.

@jbogarthyde jbogarthyde added this to Waiting for Approval in docs Aug 26, 2019
@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2019
@jbogarthyde
Copy link
Contributor Author

doc format only - no technical changes. Should not need code-owner review.

@mary-poppins
Copy link

You can preview ead624e at https://pr32325-ead624e.ngbuilds.io/.

@jbogarthyde jbogarthyde moved this from Waiting for Approval to Waiting for Merge in docs Aug 27, 2019
atscott pushed a commit that referenced this pull request Aug 28, 2019
@jbogarthyde @atscott
docs: fix callout header (#32325)
8ff6ed6 
PR Close #32325
@atscott atscott closed this in 2f6062f Aug 28, 2019
@jbogarthyde jbogarthyde deleted the jb-http-edit branch August 28, 2019 16:52
@jbogarthyde jbogarthyde moved this from Waiting for Merge to Done in docs Aug 29, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@jbogarthyde @sabeersulaiman
docs: fix callout header (angular#32325)
4995816 
PR Close angular#32325
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@jbogarthyde @arnehoek
docs: fix callout header (angular#32325)
8e4270e 
PR Close angular#32325
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott atscott approved these changes

Assignees

@jbogarthyde jbogarthyde

Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours freq1: low risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
docs
Done
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbogarthyde @mary-poppins @atscott @googlebot